nits for misc 7 #84
Open
nits for misc 7 #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Kivooeo
force-pushed
the
asd123
branch
2 times, most recently
from
bb3e51c to
786f15f
Compare
WaffleLapkin
requested changes
Nov 3, 2025
Comment on lines
+14
to
+17
| ``` | ||
| [src/main.rs:17:5] capture!(2 + 3) = 5 | ||
| [src/main.rs:18:5] transform!(2 + 3) = 6 | ||
| ``` |
Collaborator
There was a problem hiding this comment.
Suggested change
| ``` | |
| [src/main.rs:17:5] capture!(2 + 3) = 5 | |
| [src/main.rs:18:5] transform!(2 + 3) = 6 | |
| ``` | |
| ```text | |
| {{#include ../../code/examples/stderr/misc_7.stderr}} | |
| ``` |
Comment on lines
21
to
23
| When `capture!(2 + 3)` is invoked, the `$e:expr` matcher captures `2 + 3` as a single expression token tree. This captured expression is then passed to `transform!($e)`, which attempts to match it against the pattern `$a:tt + $b:tt`. | ||
|
|
||
| However, because `$e` was already captured as an `:expr`, it cannot be pattern-matched as separate tokens anymore. The first arm `$a:tt + $b:tt` fails to match, so the second arm `$other:expr` matches instead, and the expression `2 + 3` is returned as-is, evaluating to `5`. |
Collaborator
There was a problem hiding this comment.
You should probably tweak the explanation here so that it's clear that this stuff only happens when capture is invoked via transform. In general it would be nice if the explanation highlighted the difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.